fix decodeOp modifying the whole opcode value#63
Merged
TheGreatSageEqualToHeaven merged 1 commit intorce-incorporated:mainfrom Mar 8, 2026
Merged
fix decodeOp modifying the whole opcode value#63TheGreatSageEqualToHeaven merged 1 commit intorce-incorporated:mainfrom
TheGreatSageEqualToHeaven merged 1 commit intorce-incorporated:mainfrom
Conversation
greengrassstudios
approved these changes
Mar 8, 2026
greengrassstudios
left a comment
greengrassstudios
left a comment
There was a problem hiding this comment.
This is a pretty critical issue, and this is the proper implementation.
TheGreatSageEqualToHeaven
merged commit 0acebac
into
rce-incorporated:main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decodeOp was modifying the whole opcode word instead of just calling it for the opcode "id"
this made my inst.D have incredibly weird values which well errored in fiu
fix found from https://github.com/shrimp-nz/medal/blob/main/luau-lifter/src/instruction.rs#L118
(only apply the encode key for the opcode and not the whole "instruction")
(i do not know have the luau bytecode technical terms)